pgsql: Fix incorrect return value in JSON equality function for scalars

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix incorrect return value in JSON equality function for scalars
Date: 2019-05-13 00:17:37
Message-ID: E1hPyev-00077Y-9r@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix incorrect return value in JSON equality function for scalars

equalsJsonbScalarValue() uses a boolean as return type, however for one
code path -1 gets returned, which is confusing. The origin of the
confusion is visibly that this code got copy-pasted from
compareJsonbScalarValue() since it has been introduced in d1d50bf.

No backpatch, as this is only cosmetic.

Author: Rikard Falkeborn
Discussion: https://postgr.es/m/CADRDgG7mJnek6HNW13f+LF6V=6gag9PM+P7H5dnyWZAv49aBGg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1171dbde2daef8f0dcd1dc1e54531a0d8dd34d88

Modified Files
--------------
src/backend/utils/adt/jsonb_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2019-05-13 03:24:47 pgsql: docs: fix typo in mention of MSVC
Previous Message Tom Lane 2019-05-12 22:54:09 pgsql: Fix misoptimization of "{1, 1}" quantifiers in regular expression