From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: GSSAPI: Improve documentation and tests |
Date: | 2019-04-20 01:23:13 |
Message-ID: | E1hHein-0002ws-ND@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
GSSAPI: Improve documentation and tests
The GSSAPI encryption patch neglected to update the protocol
documentation to describe how to set up a GSSAPI encrypted connection
from a client to the server, so fix that by adding the appropriate
documentation to protocol.sgml.
The tests added for encryption support were overly long and couldn't be
run in parallel due to race conditions; this was largely because each
test was setting up its own KDC to perform the tests. Instead, merge
the authentication tests and the encryption tests into the original
test, where we only create one KDC to run the tests with. Also, have
the tests check what the server's opinion is of the connection and if it
was GSS authenticated or encrypted using the pg_stat_gssapi view.
In passing, fix the libpq label for GSSENC-Mode to be consistent with
the "PGGSSENCMODE" environment variable.
Missing protocol documentation pointed out by Michael Paquier.
Issues with the tests pointed out by Tom Lane and Peter Eisentraut.
Refactored tests and added documentation by me.
Reviewed by Robbie Harwood (protocol documentation) and Michael Paquier
(rework of the tests).
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/eb882a1b717589777e068dc6671830226f3aa7f0
Modified Files
--------------
doc/src/sgml/protocol.sgml | 106 ++++++++++++++++++++
src/interfaces/libpq/fe-connect.c | 2 +-
src/test/kerberos/t/001_auth.pl | 122 ++++++++++++++++++++---
src/test/kerberos/t/002_enc.pl | 197 --------------------------------------
4 files changed, 216 insertions(+), 211 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Laurenz Albe | 2019-04-20 11:53:26 | Re: pgsql: Allow insert and update tuple routing and COPY for foreign table |
Previous Message | Andres Freund | 2019-04-19 18:55:09 | pgsql: Fix two memory leaks around force-storing tuples in slots. |