From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Simplify some ERROR paths clearing wait events and transient fil |
Date: | 2019-04-17 00:57:09 |
Message-ID: | E1hGYsv-0000hg-0A@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Simplify some ERROR paths clearing wait events and transient files
Transient files and wait events get normally cleaned up when seeing an
exception (be it in the context of a transaction for a backend or
another process like the checkpointer), hence there is little point in
complicating error code paths to do this work. This shaves a bit of
code, and removes some extra handling with errno which needed to be
preserved during the cleanup steps done.
Reported-by: Masahiko Sawada
Author: Michael Paquier
Reviewed-by: Tom Lane, Masahiko Sawada
Discussion: https://postgr.es/m/CAD21AoDhHYVq5KkXfkaHhmjA-zJYj-e4teiRAJefvXuKJz1tKQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/47ac2033d460cefbbda2e39732e18de521dc6a36
Modified Files
--------------
src/backend/access/transam/twophase.c | 22 ++++------------------
src/backend/replication/logical/origin.c | 21 ++++++---------------
src/backend/replication/slot.c | 14 --------------
src/backend/storage/file/copydir.c | 1 -
4 files changed, 10 insertions(+), 48 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2019-04-17 01:11:35 | pgsql: Fix thinko introduced by 82a5649 in slot.c |
Previous Message | Michael Paquier | 2019-04-17 00:41:32 | pgsql: Rework handling of invalid indexes with REINDEX CONCURRENTLY |