pgsql: Switch TAP tests of pg_rewind to use a role with minimal permiss

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Switch TAP tests of pg_rewind to use a role with minimal permiss
Date: 2019-04-12 01:56:47
Message-ID: E1hElQt-0002CM-4A@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Switch TAP tests of pg_rewind to use a role with minimal permissions

Up to now the tests of pg_rewind have been using a superuser for all the
tests (which is the default of many tests actually, and something that
ought to be reviewed) when involving an online source server, still it
is possible to use a non-superuser role to do that as long as this role
is granted permissions to execute all the source-side functions used for
the rewind. This is possible since v11, and was already documented as
of bfc8068.

This will allow to catch up easily any change in pg_rewind if the tool
begins to use more backend-side functions, so as the properties
introduced by v11 are kept.

Per suggestion from Peter Eisentraut.

Author: Michael Paquier
Reviewed-by: Magnus Hagander
Discussion: https://postgr.es/m/20190411041336.GM2728@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d4e2a843e6d6f325c070ee80a0c117ec11675e74

Modified Files
--------------
src/bin/pg_rewind/t/RewindTest.pm | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-04-12 03:59:44 pgsql: Fix typos in reloptions.c
Previous Message Michael Paquier 2019-04-12 01:28:25 pgsql: Fix more strcmp() calls using boolean-like comparisons for resul