pgsql: Remove duplicative polygon SP-GiST sequencing test.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove duplicative polygon SP-GiST sequencing test.
Date: 2019-04-11 18:35:54
Message-ID: E1hEeYE-0001p1-Dy@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove duplicative polygon SP-GiST sequencing test.

Code coverage comparisons confirm that the tests using
quad_poly_tbl_ord_seq1/quad_poly_tbl_ord_idx1 hit no code
paths not also covered by the similar tests using
quad_poly_tbl_ord_seq2/quad_poly_tbl_ord_idx2. Since these
test cases are pretty expensive, they need to contribute more
than zero benefit.

In passing, make quad_poly_tbl_ord_seq2 a temp table, since
there seems little reason to keep it around after the test.

Discussion: https://postgr.es/m/735.1554935715@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4aaa3b5cf1c33d713b8eefa3612a9112cbcf1074

Modified Files
--------------
src/test/regress/expected/polygon.out | 27 +--------------------------
src/test/regress/expected/sanity_check.out | 2 --
src/test/regress/sql/polygon.sql | 21 +--------------------
3 files changed, 2 insertions(+), 48 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Meskes 2019-04-11 19:06:36 pgsql: Fix off-by-one check that can lead to a memory overflow in ecpg.
Previous Message Bruce Momjian 2019-04-11 17:25:49 pgsql: doc: adjust libpq wording to be neither/nor