pgsql: Remove redundant and ineffective test for btree insertion fast p

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove redundant and ineffective test for btree insertion fast p
Date: 2019-04-11 17:16:08
Message-ID: E1hEdJ2-0008JH-AB@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove redundant and ineffective test for btree insertion fast path.

indexing.sql's test for this feature was added along with the
feature in commit 2b2727343. However, shortly later that test was
rendered ineffective by commit 074251db6, which limited when the
optimization would be applied, so that the test didn't test it.
Since then, commit dd299df81 added new tests (in btree_index.sql)
that actually do test the feature. Code coverage comparisons
confirm that this test sequence adds no meaningful coverage, and
it's rather expensive, accounting for nearly half of the runtime
of indexing.sql according to my measurements. So let's remove it.

Per advice from Peter Geoghegan.

Discussion: https://postgr.es/m/735.1554935715@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f72d9a5e7dda5f89336a60e8b720ef9964a67177

Modified Files
--------------
src/test/regress/expected/indexing.out | 233 ---------------------------------
src/test/regress/sql/indexing.sql | 114 ----------------
2 files changed, 347 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-04-11 17:17:44 Re: pgsql: Fix memory leak in pgbench
Previous Message Fabien COELHO 2019-04-11 16:36:16 Re: pgsql: Fix memory leak in pgbench