pgsql: Additional fixes of memory alignment in pg_mcv_list code

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Additional fixes of memory alignment in pg_mcv_list code
Date: 2019-03-30 18:47:34
Message-ID: E1hAJ0w-0006pS-JK@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Additional fixes of memory alignment in pg_mcv_list code

Commit d85e0f366a tried to fix memory alignment issues in serialization
and deserialization of pg_mcv_list values, but it was a few bricks shy.
The arrays of uint16 indexes in serialized items was not aligned, and
the both the values and isnull flags were using the same pointer.

Per investigation by Tom Lane on gaur.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ea4e1c0e8f583f99c8caab5bcdfbbbaaed0685c0

Modified Files
--------------
src/backend/statistics/mcv.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2019-03-30 19:19:57 Re: pgsql: Compute XID horizon for page level index vacuum on primary.
Previous Message Tom Lane 2019-03-30 16:48:53 pgsql: Avoid crash in partitionwise join planning under GEQO.