pgsql: Switch function current_schema[s]() to be parallel-unsafe

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Switch function current_schema[s]() to be parallel-unsafe
Date: 2019-03-27 02:36:01
Message-ID: E1h8yQ5-0001Hm-KG@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Switch function current_schema[s]() to be parallel-unsafe

When invoked for the first time in a session, current_schema() and
current_schemas() can finish by creating a temporary schema. Currently
those functions are parallel-safe, however if for a reason or another
they get launched across multiple parallel workers, they would fail when
attempting to create a temporary schema as temporary contexts are not
supported in this case.

The original issue has been spotted by buildfarm members crake and
lapwing, after commit c5660e0 has introduced the first regression tests
based on current_schema() in the tree. After that, 396676b has
introduced a workaround to avoid parallel plans but that was not
completely right either.

Catversion is bumped.

Author: Michael Paquier
Reviewed-by: Daniel Gustafsson
Discussion: https://postgr.es/m/20190118024618.GF1883@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5bde1651bbba9984dc32bbeb68b329cfd3f92767

Modified Files
--------------
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.dat | 8 ++++----
src/test/regress/expected/temp.out | 5 +----
src/test/regress/sql/temp.sql | 5 +----
4 files changed, 7 insertions(+), 13 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-03-27 03:03:10 pgsql: Switch some palloc/memset calls to palloc0
Previous Message Tomas Vondra 2019-03-27 02:33:48 pgsql: Track unowned relations in doubly-linked list