From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: tableam: Use in CREATE TABLE AS and CREATE MATERIALIZED VIEW. |
Date: | 2019-03-25 02:05:47 |
Message-ID: | E1h8Ezj-0001g2-Qj@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
tableam: Use in CREATE TABLE AS and CREATE MATERIALIZED VIEW.
Previously those directly performed a heap_insert(). Use
table_insert() instead. The input slot of those routines is not of
the target relation - we could fix that by copying if necessary, but
that'd not be beneficial for performance. As those codepaths don't
access any AM specific tuple fields (say xmin/xmax), there's no need
to use an AM specific slot.
Author: Andres Freund
Reviewed-By: Haribabu Kommi
Discussion: https://postgr.es/m/20180703070645.wchpu5muyto5n647@alap3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/919e48b943014b1d4ab5d83e48dbc9f8e87e7be4
Modified Files
--------------
src/backend/commands/createas.c | 24 ++++++++++++------------
src/backend/commands/matview.c | 23 +++++++++++------------
2 files changed, 23 insertions(+), 24 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-03-25 05:07:46 | Re: pgsql: Collations with nondeterministic comparison |
Previous Message | Tom Lane | 2019-03-24 23:15:46 | pgsql: Un-hide most cascaded-drop details in regression test results. |