pgsql: Don't auto-restart per-database autoprewarm workers.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Don't auto-restart per-database autoprewarm workers.
Date: 2019-03-18 19:35:26
Message-ID: E1h5y2g-0005OG-2N@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't auto-restart per-database autoprewarm workers.

We should try to prewarm each database only once. Otherwise, if
prewarming fails for some reason, it will just keep retrying in an
infnite loop. This can happen if, for example, the database has been
dropped. The existing code was intended to implement the try-once
behavior, but failed to do so because it neglected to set
worker.bgw_restart_time to BGW_NEVER_RESTART.

Mithun Cy, per a report from Hans Buschmann

Discussion: http://postgr.es/m/CA+hUKGKpQJCWcgyy3QTC9vdn6uKAR_8r__A-MMm2GYfj45caag@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1459e84cb2e57649627753ad1279428d35590df6

Modified Files
--------------
contrib/pg_prewarm/autoprewarm.c | 1 +
1 file changed, 1 insertion(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2019-03-18 20:16:45 pgsql: Remove leftover reference to oid column.
Previous Message Robert Haas 2019-03-18 19:19:48 pgsql: Revise parse tree representation for VACUUM and ANALYZE.