pgsql: Give up on testing guc.c's behavior for "infinity" inputs.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Give up on testing guc.c's behavior for "infinity" inputs.
Date: 2019-03-11 21:53:18
Message-ID: E1h3SrG-00089Z-P0@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Give up on testing guc.c's behavior for "infinity" inputs.

Further buildfarm testing shows that on the machines that are failing
ac75959cd's test case, what we're actually getting from strtod("-infinity")
is a syntax error (endptr == value) not ERANGE at all. This test case
is not worth carrying two sets of expected output for, so just remove it,
and revert commit b212245f9's misguided attempt to work around the platform
dependency.

Discussion: https://postgr.es/m/E1h33xk-0001Og-Gs@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d9c5e9629bf511a51328fd083ee452de88d91d9d

Modified Files
--------------
src/backend/utils/misc/guc.c | 12 +++++-------
src/test/regress/expected/guc.out | 2 --
src/test/regress/sql/guc.sql | 1 -
3 files changed, 5 insertions(+), 10 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2019-03-11 22:07:17 pgsql: Remove spurious return.
Previous Message Andres Freund 2019-03-11 21:27:11 pgsql: Ensure sufficient alignment for ParallelTableScanDescData in BTS