pgsql: In guc.c, ignore ERANGE errors from strtod().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: In guc.c, ignore ERANGE errors from strtod().
Date: 2019-03-11 15:25:38
Message-ID: E1h3Mo6-0000Fk-U5@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

In guc.c, ignore ERANGE errors from strtod().

Instead, just proceed with the infinity or zero result that it should
return for overflow/underflow. This avoids a platform dependency,
in that various versions of strtod are inconsistent about whether they
signal ERANGE for a value that's specified as infinity.

It's possible this won't be enough to remove the buildfarm failures
we're seeing from ac75959cd, in which case I'll take out the infinity
test case that commit added. But first let's see if we can fix it.

Discussion: https://postgr.es/m/E1h33xk-0001Og-Gs@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b212245f96437b574b59993c772e4d9276965e49

Modified Files
--------------
src/backend/utils/misc/guc.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Meskes 2019-03-11 15:27:08 pgsql: Fix potential memory access violation in ecpg if filename of inc
Previous Message Michael Meskes 2019-03-11 15:18:43 pgsql: Fix potential memory access violation in ecpg if filename of inc