pgsql: Fix pgbench TAP test failure with funky file names (redux)

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix pgbench TAP test failure with funky file names (redux)
Date: 2019-03-05 15:51:17
Message-ID: E1h1CLd-00054z-Pi@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pgbench TAP test failure with funky file names (redux)

This test fails if the containing directory contains a funny character
such as a space or some perl metacharacter. To avoid that, we check for
files names using readdir and a regex, rather than using a glob pattern.

Discussion: https://postgr.es/m/CAM6_UM6dGdU39PKAC24T+HD9ouy0jLN9vH6163K8QEEzr__iZw@mail.gmail.com

Author: Fabien COELHO
Reviewed-by: Raúl Marín Rodríguez

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f1b864ee6774e86ad4c6a5423722c354c7f706fd

Modified Files
--------------
src/bin/pgbench/t/001_pgbench_with_server.pl | 53 ++++++++++++++++++++--------
1 file changed, 39 insertions(+), 14 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2019-03-05 19:02:12 pgsql: Disable dump_connstr test on Msys2
Previous Message Peter Eisentraut 2019-03-05 14:03:57 pgsql: Remove duplicate macro