| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix mark-and-restore-skipping test case to not be a self-join. |
| Date: | 2019-02-21 23:55:35 |
| Message-ID: | E1gwyBj-0007N3-Tw@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix mark-and-restore-skipping test case to not be a self-join.
There isn't any good reason for this test to be a self-join rather
than a join between separate tables, except that it saved a couple
of SQL commands for setup. A proposed patch to optimize away
self-joins breaks the test, so adjust it to avoid that happening.
Discussion: https://postgr.es/m/64486b0b-0404-e39e-322d-0801154901f3@postgrespro.ru
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/24d08f3c0a1f04ea8bac68eb3aa3b069680e43f5
Modified Files
--------------
src/test/regress/expected/join.out | 20 ++++++++++++--------
src/test/regress/sql/join.sql | 15 ++++++++++-----
2 files changed, 22 insertions(+), 13 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-02-22 04:22:18 | pgsql: Remove duplicate variable declaration in fe-connect.c |
| Previous Message | Tom Lane | 2019-02-21 19:59:23 | pgsql: Move estimate_hashagg_tablesize to selfuncs.c, and widen result |