pgsql: Revert attempts to use POPCNT etc instructions

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Revert attempts to use POPCNT etc instructions
Date: 2019-02-15 19:32:55
Message-ID: E1gujEF-0005c5-Jn@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert attempts to use POPCNT etc instructions

This reverts commits fc6c72747ae6, 109de05cbb03, d0b4663c23b7 and
711bab1e4d19.

Somebody will have to try harder before submitting this patch again.
I've spent entirely too much time on it already, and the #ifdef maze yet
to be written in order for it to build at all got on my nerves. The
amount of work needed to get a platform-specific performance improvement
that's barely above the noise level is not worth it.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/457aef0f1fd365c68fab3fa2ca3ae48c5bd230c6

Modified Files
--------------
config/c-compiler.m4 | 52 --------
configure | 119 -----------------
configure.in | 9 --
src/Makefile.global.in | 4 -
src/backend/access/heap/visibilitymap.c | 73 +++++++----
src/backend/lib/bloomfilter.c | 15 ++-
src/backend/nodes/bitmapset.c | 131 +++++++++++++++----
src/include/pg_config.h.in | 9 --
src/include/pg_config.h.win32 | 9 --
src/include/port/pg_bitutils.h | 186 ---------------------------
src/port/Makefile | 15 +--
src/port/pg_bitutils.c | 219 --------------------------------
src/port/pg_bitutils_hwpopcnt.c | 36 ------
src/tools/msvc/Mkvcbuild.pm | 1 -
14 files changed, 169 insertions(+), 709 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2019-02-15 19:36:49 Re: pgsql: Fix compiler builtin usage in new pg_bitutils.c
Previous Message Tom Lane 2019-02-15 18:50:15 Re: pgsql: Fix compiler builtin usage in new pg_bitutils.c