From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix race in dsm_attach() when handles are reused. |
Date: | 2019-02-15 02:06:21 |
Message-ID: | E1guStR-0001Yu-0G@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix race in dsm_attach() when handles are reused.
DSM handle values can be reused as soon as the underlying shared memory
object has been destroyed. That means that for a brief moment we
might have two DSM slots with the same handle. While trying to attach,
if we encounter a slot with refcnt == 1, meaning that it is currently
being destroyed, we should continue our search in case the same handle
exists in another slot.
The race manifested as a rare "dsa_area could not attach to segment"
error, and was more likely in 10 and 11 due to the lack of distinct
seed for random() in parallel workers. It was made very unlikely in
in master by commit 197e4af9, and older releases don't usually create
new DSM segments in background workers so it was also unlikely there.
This fixes the root cause of bug report #15585, in which the error
could also sometimes result in a self-deadlock in the error path.
It's not yet clear if further changes are needed to avoid that failure
mode.
Back-patch to 9.4, where dsm.c arrived.
Author: Thomas Munro
Reported-by: Justin Pryzby, Sergei Kornilov
Discussion: https://postgr.es/m/20190207014719.GJ29720@telsasoft.com
Discussion: https://postgr.es/m/15585-324ff6a93a18da46@postgresql.org
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/cb3d674e1709362d84b5e25c94e690e98599a33c
Modified Files
--------------
src/backend/storage/ipc/dsm.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2019-02-15 02:06:40 | pgsql: Fix race in dsm_attach() when handles are reused. |
Previous Message | Thomas Munro | 2019-02-15 02:05:59 | pgsql: Fix race in dsm_attach() when handles are reused. |