From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Ensure that foreign scans with lateral refs are planned correctl |
Date: | 2019-02-07 18:11:33 |
Message-ID: | E1gro97-00007N-9S@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Ensure that foreign scans with lateral refs are planned correctly.
As reported in bug #15613 from Srinivasan S A, file_fdw and postgres_fdw
neglected to mark plain baserel foreign paths as parameterized when the
relation has lateral_relids. Other FDWs have surely copied this mistake,
so rather than just patching those two modules, install a band-aid fix
in create_foreignscan_path to rectify the mistake centrally.
Although the band-aid is enough to fix the visible symptom, correct
the calls in file_fdw and postgres_fdw anyway, so that they are valid
examples for external FDWs.
Also, since the band-aid isn't enough to make this work for parameterized
foreign joins, throw an elog(ERROR) if such a case is passed to
create_foreignscan_path. This shouldn't pose much of a problem for
existing external FDWs, since it's likely they aren't trying to make such
paths anyway (though some of them may need a defense against joins with
lateral_relids, similar to the one this patch installs into postgres_fdw).
Add some assertions in relnode.c to catch future occurrences of the same
error --- in particular, as backstop against core-code mistakes like the
one fixed by commit bdd9a99aa.
Discussion: https://postgr.es/m/15613-092be1be9576c728@postgresql.org
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/9d6d2b21343db76a769fbcae72fbcbc18aa388cb
Modified Files
--------------
contrib/file_fdw/file_fdw.c | 6 ++-
contrib/postgres_fdw/expected/postgres_fdw.out | 56 ++++++++++++++++++++++++++
contrib/postgres_fdw/postgres_fdw.c | 18 +++++++--
contrib/postgres_fdw/sql/postgres_fdw.sql | 26 ++++++++++++
src/backend/optimizer/util/pathnode.c | 21 ++++++++++
src/backend/optimizer/util/relnode.c | 9 +++++
6 files changed, 131 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2019-02-08 00:07:26 | pgsql: Add pg_partition_root to display top-most parent of a partition |
Previous Message | Andrew Dunstan | 2019-02-07 16:15:28 | pgsql: Fix perl searchpath for gen_keywordlist.pl |