pgsql: Fix handling of volatile expressions in COPY FROM ... WHERE

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix handling of volatile expressions in COPY FROM ... WHERE
Date: 2019-01-22 23:03:26
Message-ID: E1gm54o-0007zC-Ai@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix handling of volatile expressions in COPY FROM ... WHERE

The checking for calls to volatile functions in the COPY FROM ... WHERE
expression was treating all WHERE clauses as if containing such calls.
While that does not produce incorrect results, this disables batching
which may result in significant performance regression.

Discussion: https://www.postgresql.org/message-id/flat/CALAY4q_DdpWDuB5-Zyi-oTtO2uSk8pmy+dupiRe3AvAc++1imA(at)mail(dot)gmail(dot)com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4a8283d0ec5a6781b9e0d4ba16b44da8a0856d02

Modified Files
--------------
src/backend/commands/copy.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-01-23 01:11:10 pgsql: Make vacuumdb test regex more modular for its query output
Previous Message Andres Freund 2019-01-22 19:51:39 pgsql: llvm: Fix file-ending in IDENTIFICATION comments.