From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Use our own getopt() on OpenBSD. |
Date: | 2019-01-18 20:06:49 |
Message-ID: | E1gkaPh-0007gi-Iv@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Use our own getopt() on OpenBSD.
Recent OpenBSD (at least 5.9 and up) has a version of getopt(3)
that will not cope with the "-:" spec we use to accept double-dash
options in postgres.c and postmaster.c. Admittedly, that's a hack
because POSIX only requires getopt() to allow alphanumeric option
characters. I have no desire to find another way, however, so
let's just do what we were already doing on Solaris: force use
of our own src/port/getopt.c implementation.
In passing, improve some of the comments around said implementation.
Per buildfarm and local testing. Back-patch to all supported branches.
Discussion: https://postgr.es/m/30197.1547835700@sss.pgh.pa.us
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/139e4274263a7efa230353e7b857cfa75703044a
Modified Files
--------------
configure | 6 +++---
configure.in | 6 +++---
src/include/pg_getopt.h | 10 ++++++++++
src/port/getopt.c | 11 +++++------
4 files changed, 21 insertions(+), 12 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-01-18 20:23:49 | pgsql: Fix under-quoted filename pattern in pgbench TAP test. |
Previous Message | Robert Haas | 2019-01-18 20:05:02 | Re: pgsql: Restrict the use of temporary namespace in two-phase transaction |