| From: | Etsuro Fujita <efujita(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: postgres_fdw: Remove duplicate code in DML execution callback fu |
| Date: | 2019-01-17 05:41:21 |
| Message-ID: | E1gk0Qb-0003yn-PX@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
postgres_fdw: Remove duplicate code in DML execution callback functions.
postgresExecForeignInsert(), postgresExecForeignUpdate(), and
postgresExecForeignDelete() are coded almost identically, except that
postgresExecForeignInsert() does not need CTID. Extract that code into
a separate function and use it in all the three function implementations.
Author: Ashutosh Bapat
Reviewed-By: Michael Paquier
Discussion: https://postgr.es/m/CAFjFpRcz8yoY7cBTYofcrCLwjaDeCcGKyTUivUbRiA57y3v-bw%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6c61d7c5935793e218d2335ac540a2cea7eacdce
Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c | 283 +++++++++++++-----------------------
1 file changed, 103 insertions(+), 180 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2019-01-17 06:43:32 | pgsql: Doc: enhance pgbench manual. |
| Previous Message | Peter Eisentraut | 2019-01-16 20:00:10 | Re: pgsql: Increase test coverage in RI_FKey_pk_upd_check_required() |