pgsql: Move inheritance expansion code into its own file

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Move inheritance expansion code into its own file
Date: 2019-01-10 17:56:32
Message-ID: E1gheZE-0002rn-LA@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Move inheritance expansion code into its own file

This commit moves expand_inherited_tables and underlings from
optimizer/prep/prepunionc.c to optimizer/utils/inherit.c.
Also, all of the AppendRelInfo-based expression manipulation routines
are moved to optimizer/utils/appendinfo.c.

No functional code changes. One exception is the introduction of
make_append_rel_info, but that's still just moving around code.

Also, stop including <limits.h> in prepunion.c, which no longer needs
it since 3fc6e2d7f5b6. I (Álvaro) noticed this because Amit was copying
that to inherit.c, which likewise doesn't need it.

Author: Amit Langote
Discussion: https://postgr.es/m/3be67028-a00a-502c-199a-da00eec8fb6e@lab.ntt.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b60c39759908bb2a2dbcfc108ec19bdbdcc278e8

Modified Files
--------------
src/backend/optimizer/path/allpaths.c | 3 +-
src/backend/optimizer/path/equivclass.c | 2 +-
src/backend/optimizer/path/joinrels.c | 2 +-
src/backend/optimizer/plan/planmain.c | 2 +
src/backend/optimizer/plan/planner.c | 2 +
src/backend/optimizer/prep/prepunion.c | 1204 -------------------------------
src/backend/optimizer/util/Makefile | 5 +-
src/backend/optimizer/util/appendinfo.c | 826 +++++++++++++++++++++
src/backend/optimizer/util/inherit.c | 439 +++++++++++
src/backend/optimizer/util/pathnode.c | 1 +
src/backend/optimizer/util/relnode.c | 1 +
src/backend/partitioning/partprune.c | 1 +
src/include/optimizer/appendinfo.h | 42 ++
src/include/optimizer/inherit.h | 22 +
src/include/optimizer/prep.h | 18 -
15 files changed, 1343 insertions(+), 1227 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-01-10 18:12:47 Re: pgsql: Move inheritance expansion code into its own file
Previous Message Alvaro Herrera 2019-01-10 17:00:45 pgsql: Don't use address of array as boolean