From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Improve comments and logs in do_pg_stop/start_backup |
Date: | 2019-01-01 00:03:45 |
Message-ID: | E1ge7X7-0002qn-MB@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve comments and logs in do_pg_stop/start_backup
The function name pg_stop_backup() has been included for ages in some
log messages when stopping the backup, which is confusing for base
backups taken with the replication protocol because this function is
never called. Some other comments and messages in this area are
improved while on it.
The new wording is based on input and suggestions from several people,
all listed below.
Author: Michael Paquier
Reviewed-by: Peter Eisentraut, Álvaro Herrera, Tom Lane
Discussion: https://postgr.es/m/20181221040510.GA12599@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8d3b389ec3405659d8e2968fc6179b28b286ccd8
Modified Files
--------------
src/backend/access/transam/xlog.c | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2019-01-01 01:40:23 | pgsql: Fix generation of padding message before encrypting Elgamal in p |
Previous Message | Noah Misch | 2018-12-31 22:18:37 | pgsql: Send EXTRA_INSTALL errors to install.log, not stderr. |