pgsql: Make error handling in parallel pg_upgrade less bogus.

Make error handling in parallel pg_upgrade less bogus.

reap_child() basically ignored the possibility of either an error in
waitpid() itself or a child process failure on signal. We don't really
need to do more than report and crash hard, but proceeding as though
nothing is wrong is definitely Not Acceptable. The error report for
nonzero child exit status was pretty off-point, as well.

Noted while fooling around with child-process failure detection
logic elsewhere. It's been like this a long time, so back-patch to
all supported branches.

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b054498c74c3630348b9a35f7f4c6dc90e204643

Modified Files
--------------
src/bin/pg_upgrade/parallel.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)