pgsql: Fix bogus logic for skipping unnecessary partcollation dependenc

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix bogus logic for skipping unnecessary partcollation dependenc
Date: 2018-12-13 20:11:48
Message-ID: E1gXXKm-0007sI-Bb@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix bogus logic for skipping unnecessary partcollation dependencies.

The idea here is to not call recordDependencyOn for the default collation,
since we know that's pinned. But what the code actually did was to record
the partition key's dependency on the opclass twice, instead.

Evidently introduced by sloppy coding in commit 2186b608b. Back-patch
to v10 where that came in.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/84d514887f9ca673ae688d00f8b544e70f1ab270

Modified Files
--------------
src/backend/catalog/heap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-12-13 22:51:55 pgsql: Create a separate oid range for oids assigned by genbki.pl.
Previous Message Alexander Korotkov 2018-12-13 19:38:47 pgsql: Fix wrong backpatching of ginRedoDeletePage() deadlock fix