pgsql: Add support for NO_INSTALLCHECK in MSVC scripts

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add support for NO_INSTALLCHECK in MSVC scripts
Date: 2018-11-29 01:32:31
Message-ID: E1gSBBv-0007KD-JJ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add support for NO_INSTALLCHECK in MSVC scripts

When fetching a list of tests for a given extension in contrib/ or
src/test/modules/, NO_INSTALLCHECK now gets checked first. If present,
an empty list of tests is returned to let the caller know that tests
for this module need to be bypassed.

This actually fixes a set of issues with MSVC with modules using
REGRESS_OPTS, as an incorrect parsing caused the launched command
to eat the first test listed. The actual effect on the tree is that
several modules listed a single test, so regressions have been running
with no actual tests. pg_stat_statements, test_rls_hooks and commit_ts
were impacted by that. Some other modules like test_decoding (or
snapshot_too_old) don't use yet PGXS rules, but their makefiles will
soon be refactored with an upcoming patch.

Author: Michael Paquier
Reviewed-by: Andrew Dunstan
Discussion: https://postgr.es/m/20181126054302.GI1776@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/431f1599a2b7ba3e42fc06bd5b0ff5735931f556

Modified Files
--------------
src/tools/msvc/vcregress.pl | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-11-29 09:03:50 pgsql: Add pg_partition_tree to documentation index
Previous Message Thomas Munro 2018-11-29 01:17:19 pgsql: Fix minor typo in dsa.c.