From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Adjust new test case for more portability. |
Date: | 2018-11-24 04:49:33 |
Message-ID: | E1gQPsr-0002MC-Or@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Adjust new test case for more portability.
Early returns from the buildfarm say that most critters are good with
commit cbdb8b4c0, but gaur gives unexpected results with the test case
involving a float8 that's one-ULP-less-than-2^63. It appears that that
platform's version of rint() rounds that value up to 2^63 instead of
leaving it be. This is possibly a bug, and it's also possible that no
other platform anybody is using anywhere behaves likewise. Still, the
point of the test is not to insist that everybody's rint() behaves exactly
the same. Let's use two-ULPs-less-than-2^63 instead, which I've tested
to act the same on gaur as on more modern hardware.
(This is, more or less, exactly the portability issue I'd feared might
arise...)
Discussion: https://postgr.es/m/15519-4fc785b483201ff1@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/452b637d4b02e4aa09d45a34d7a048d3f70116bb
Modified Files
--------------
src/test/regress/expected/float8-small-is-zero.out | 4 ++--
src/test/regress/expected/float8.out | 4 ++--
src/test/regress/sql/float8.sql | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Gierth | 2018-11-24 08:53:34 | pgsql: Avoid crashes in contrib/intarray gist__int_ops (bug #15518) |
Previous Message | Tom Lane | 2018-11-24 01:57:17 | pgsql: Fix float-to-integer coercions to handle edge cases correctly. |