From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Disallow COPY FREEZE on partitioned tables |
Date: | 2018-11-19 14:17:04 |
Message-ID: | E1gOkMK-0005Ac-Ne@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Disallow COPY FREEZE on partitioned tables
This didn't actually work: COPY would fail to flush the right files, and
instead would try to flush a non-existing file, causing the whole
transaction to fail.
Cope by raising an error as soon as the command is sent instead, to
avoid a nasty later surprise. Of course, it would be much better to
make it work, but we don't have a patch for that yet, and we don't know
if we'll want to backpatch one when we do.
Reported-by: Tomas Vondra
Author: David Rowley
Reviewed-by: Amit Langote, Steve Singer, Tomas Vondra
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a4db7fe0f71463eb7256d3c42b7a582d3943d604
Modified Files
--------------
doc/src/sgml/perform.sgml | 4 ++--
doc/src/sgml/ref/copy.sgml | 4 +++-
src/backend/commands/copy.c | 29 +++++++++++++++++++++++++++--
src/test/regress/input/copy.source | 29 +++++++++++++++++++++++++++++
src/test/regress/output/copy.source | 23 +++++++++++++++++++++++
5 files changed, 84 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-11-19 17:02:10 | pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan |
Previous Message | Peter Eisentraut | 2018-11-19 07:57:41 | pgsql: pg_archivecleanup: Update file header comment a bit |