pgsql: Fix realfailN lexer rules to not make assumptions about input fo

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix realfailN lexer rules to not make assumptions about input fo
Date: 2018-11-13 19:54:48
Message-ID: E1gMels-0000MB-Tc@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix realfailN lexer rules to not make assumptions about input format.

The realfail1 and realfail2 backup-prevention rules always returned
token type FCONST, ignoring the possibility that what we've scanned
is more appropriately described as ICONST. I think that at the
time that code was added, it might actually have been safe to not
distinguish; but since we started allowing AS-less aliases in SELECT
target lists, it's definitely legal to have a number immediately
followed by an identifier.

In the SELECT case, it seems there's no visible consequence because
make_const() will change the type back to integer anyway. But I'm
worried that there are other contexts, or will be in future, where
it's more important to get the constant's type right.

Hence, use process_integer_literal to correctly determine which
token type to return.

Arguably this is a bug fix, but given the lack of evidence of
user-visible problems, I'll refrain from back-patching.

Discussion: https://postgr.es/m/21364.1542136808@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/965a3d6be0702fa88c6eaa6946fa86218704c7d2

Modified Files
--------------
src/backend/parser/scan.l | 18 +++++++++---------
src/fe_utils/psqlscan.l | 7 +++----
src/interfaces/ecpg/preproc/pgc.l | 18 +++++++++---------
3 files changed, 21 insertions(+), 22 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-11-13 20:46:32 pgsql: Fix incorrect results for numeric data passed through an ECPG SQ
Previous Message Tom Lane 2018-11-13 18:04:23 pgsql: Remove unused code in ECPG.