pgsql: Simplify null-element handling in extension_config_remove().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Simplify null-element handling in extension_config_remove().
Date: 2018-11-12 16:50:31
Message-ID: E1gMFPz-0001rj-Mk@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simplify null-element handling in extension_config_remove().

There's no point in asking deconstruct_array() for a null-flags
array when we already checked the array has no nulls, and aren't
going to examine the output anyhow. Not asking for this output
should make the code marginally faster, and it's also more
robust since if there somehow were nulls, deconstruct_array()
would throw an error.

Daniel Gustafsson

Discussion: https://postgr.es/m/289FFB8B-7AAB-48B5-A497-6E0D41D7BA47@yesql.se

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3de491482b6c815a2e735dbbb8972e0907d75188

Modified Files
--------------
src/backend/commands/extension.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-11-13 00:04:38 pgsql: Remove CommandCounterIncrement() after processing ON COMMIT DELE
Previous Message Tom Lane 2018-11-12 16:20:05 pgsql: Limit the number of index clauses considered in choose_bitmap_an