pgsql: Rename rbtree.c functions to use "rbt" prefix not "rb" prefix.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Rename rbtree.c functions to use "rbt" prefix not "rb" prefix.
Date: 2018-11-06 18:25:38
Message-ID: E1gK62k-00073d-Rx@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Rename rbtree.c functions to use "rbt" prefix not "rb" prefix.

The "rb" prefix is used by Ruby, so that our existing code results
in name collisions that break plruby. We discussed ways to prevent
that by adjusting dynamic linker options, but it seems that at best
we'd move the pain to other cases. Renaming to avoid the collision
is the only portable fix anyway. Fortunately, our rbtree code is
not (yet?) widely used --- in core, there's only a single usage
in GIN --- so it seems likely that we can get away with a rename.

I chose to do this basically as s/rb/rbt/g, except for places where
there already was a "t" after "rb". The patch could have been made
smaller by only touching linker-visible symbols, but it would have
resulted in oddly inconsistent-looking code. Better to make it look
like "rbt" was the plan all along.

Back-patch to v10. The rbtree.c code exists back to 9.5, but
rb_iterate() which is the actual immediate source of pain was added
in v10, so it seems like changing the names before that would have
more risk than benefit.

Per report from Pavel Raiskup.

Discussion: https://postgr.es/m/4738198.8KVIIDhgEB@nb.usersys.redhat.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/003c68a3b45d0d135b874acfe04cf3fb79a6f172

Modified Files
--------------
src/backend/access/gin/ginbulk.c | 32 +--
src/backend/lib/rbtree.c | 349 +++++++++++++++--------------
src/include/access/gin_private.h | 2 +-
src/include/lib/rbtree.h | 58 ++---
src/test/modules/test_rbtree/test_rbtree.c | 90 ++++----
5 files changed, 267 insertions(+), 264 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2018-11-06 18:40:17 pgsql: GUC: adjust effective_cache_size SQL descriptions
Previous Message Emre Hasegeli 2018-11-06 17:40:21 Re: New Defects reported by Coverity Scan for PostgreSQL