From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Prevent generating EEOP_AGG_STRICT_INPUT_CHECK operations when n |
Date: | 2018-11-03 23:08:24 |
Message-ID: | E1gJ51k-0002sM-E9@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Prevent generating EEOP_AGG_STRICT_INPUT_CHECK operations when nargs == 0.
This only became a problem with 4c640f4f38, which didn't synchronize
the value agg_strict_input_check.nargs is set to, with the guard
condition for emitting the operation.
Besides such instructions being unnecessary overhead, currently the
LLVM JIT provider doesn't support them. It seems more sensible to
avoid generating such instruction than supporting them. Add assertions
to make it easier to debug a potential further occurance.
Discussion: https://postgr.es/m/2a505161-2727-2473-7c46-591ed108ac52@email.cz
Backpatch: 11-, like 4c640f4f38.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/793beab37e8f7ec6a4ef39395c6c866d7e4c7af5
Modified Files
--------------
src/backend/executor/execExpr.c | 2 +-
src/backend/jit/llvm/llvmjit_expr.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2018-11-03 23:08:25 | pgsql: Prevent generating EEOP_AGG_STRICT_INPUT_CHECK operations when n |
Previous Message | Andres Freund | 2018-11-03 21:49:13 | pgsql: Fix STRICT check for strict aggregates with NULL ORDER BY column |