| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix STRICT check for strict aggregates with NULL ORDER BY column |
| Date: | 2018-11-03 21:49:12 |
| Message-ID: | E1gJ3n6-0001EJ-BM@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix STRICT check for strict aggregates with NULL ORDER BY columns.
I (Andres) broke this unintentionally in 69c3936a14, by checking
strictness for all input expressions computed for an aggregate, rather
than just the input for the aggregate transition function.
Reported-By: Ondřej Bouda
Bisected-By: Tom Lane
Diagnosed-By: Andrew Gierth
Discussion: https://postgr.es/m/2a505161-2727-2473-7c46-591ed108ac52@email.cz
Backpatch: 11-, like 69c3936a14
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4c640f4f38d5d68cbe33ddfabbdc56eea8f1e173
Modified Files
--------------
src/backend/executor/execExpr.c | 2 +-
src/test/regress/expected/aggregates.out | 15 +++++++++++++++
src/test/regress/sql/aggregates.sql | 7 +++++++
3 files changed, 23 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-11-03 21:49:13 | pgsql: Fix STRICT check for strict aggregates with NULL ORDER BY column |
| Previous Message | Tom Lane | 2018-11-03 17:56:32 | pgsql: Make ts_locale.c's character-type functions cope with UTF-16. |