From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Disallow starting server with insufficient wal_level for existin |
Date: | 2018-10-31 22:47:35 |
Message-ID: | E1gHzGx-0000uI-Ct@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Disallow starting server with insufficient wal_level for existing slot.
Previously it was possible to create a slot, change wal_level, and
restart, even if the new wal_level was insufficient for the
slot. That's a problem for both logical and physical slots, because
the necessary WAL records are not generated.
This removes a few tests in newer versions that, somewhat
inexplicably, whether restarting with a too low wal_level worked (a
buggy behaviour!).
Reported-By: Joshua D. Drake
Author: Andres Freund
Discussion: https://postgr.es/m/20181029191304.lbsmhshkyymhw22w@alap3.anarazel.de
Backpatch: 9.4-, where replication slots where introduced
Branch
------
REL9_4_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/cf358a2c066ccb8fc9e82dc59358130aa61075ab
Modified Files
--------------
src/backend/replication/logical/logical.c | 5 +++++
src/backend/replication/slot.c | 30 ++++++++++++++++++++++++++++++
2 files changed, 35 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-11-01 06:09:11 | Re: pgsql: Avoid duplicate XIDs at recovery when building initial snapshot |
Previous Message | Andres Freund | 2018-10-31 22:47:33 | pgsql: Disallow starting server with insufficient wal_level for existin |