| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Consolidate cross-option checks in pg_restore |
| Date: | 2018-10-30 02:39:19 |
| Message-ID: | E1gHJw7-0007Ul-VX@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Consolidate cross-option checks in pg_restore
This moves one check for conflicting options from the archive restore
code to the main function where other similar checks are performed.
Also reword the error message to be consistent with other messages.
The only option combination impacted is --create specified with
--single-transaction, and informing the caller at an early step saves
from opening the archive worked on. A TAP test is added for this
combination.
Author: Daniel Gustafsson
Reviewed-by: Fabien Coelho
Discussion: https://postgr.es/m/616808BD-4B59-4E6C-97A9-7317F62D5570@yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c34bca9ea55e1d7c207ebc30691a8d2b421100eb
Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 9 ---------
src/bin/pg_dump/pg_restore.c | 11 +++++++++++
src/bin/pg_dump/t/001_basic.pl | 8 +++++++-
3 files changed, 18 insertions(+), 10 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-10-30 12:24:10 | pgsql: pg_rewind: Remove unused macro |
| Previous Message | Michael Paquier | 2018-10-30 01:31:58 | pgsql: Add pg_partition_tree to display information about partitions |