pgsql: Add tab completion of EXECUTE FUNCTION for CREATE TRIGGER in psq

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add tab completion of EXECUTE FUNCTION for CREATE TRIGGER in psq
Date: 2018-10-26 00:30:52
Message-ID: E1gFq1c-0001Ae-CE@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add tab completion of EXECUTE FUNCTION for CREATE TRIGGER in psql

The change to accept EXECUTE FUNCTION as well as EXECUTE PROCEDURE in
CREATE TRIGGER (added by 0a63f99) forgot to tell psql's tab completion
system about this. In passing, add tab completion of EXECUTE
FUNCTION/PROCEDURE after a complete WHEN ( … ) clause.

This change is version-aware, with FUNCTION being selected automatically
instead of PROCEDURE depending on the backend version, PROCEDURE being
an historical grammar kept for compatibility and considered as
deprecated in v11.

Author: Dagfinn Ilmari Mannsåker
Reviewed-by: Tom Lane, Michael Paquier
Discussion: https://postgr.es/m/d8jmur4q4yc.fsf@dalvik.ping.uio.no

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/292ef6e2778afb3ecea250fc50326587543ae144

Modified Files
--------------
src/bin/psql/tab-complete.c | 67 +++++++++++++++++++++++++++++++++++++--------
1 file changed, 56 insertions(+), 11 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-10-26 04:47:34 pgsql: Improve tab completion of CREATE EVENT TRIGGER in psql
Previous Message Michael Paquier 2018-10-25 00:46:43 pgsql: Add pg_promote function