pgAdmin 4 commit: Fix syntax error when creating new pgAgent schedules

From: Dave Page <dpage(at)pgadmin(dot)org>
To: pgadmin-hackers(at)lists(dot)postgresql(dot)org
Subject: pgAdmin 4 commit: Fix syntax error when creating new pgAgent schedules
Date: 2018-10-17 11:28:35
Message-ID: E1gCk0B-0005w8-5d@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Fix syntax error when creating new pgAgent schedules with a start
date/time and exception. Fixes #3638

- Fixed syntax error.
- Update/Delete exceptions are not working, SQL is wrong.
- Wrong exception time is shown, it should shown in UTC as datatype of
the column is timestamp with out timezone.
- Added test cases for Schedule and Steps of pgAgent Job.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=50738db2b8c871869a37c0b7617687bd4efd9da3
Author: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>

Modified Files
--------------
.../pgagent/schedules/static/js/pga_schedule.js | 14 +-
.../pgagent/templates/macros/pga_exception.macros | 8 +-
.../pgagent/templates/macros/pga_schedule.macros | 2 +-
.../templates/pga_schedule/sql/pre3.4/create.sql | 6 +
.../pgagent/tests/tests_pgagent_add_schedule.py | 80 +++++++
.../pgagent/tests/tests_pgagent_add_steps.py | 69 ++++++
.../pgagent/tests/tests_pgagent_delete_schedule.py | 52 +++++
.../pgagent/tests/tests_pgagent_delete_steps.py | 52 +++++
.../pgagent/tests/tests_pgagent_put_schedule.py | 131 ++++++++++++
.../pgagent/tests/tests_pgagent_put_step.py | 67 ++++++
.../server_groups/servers/pgagent/tests/utils.py | 235 ++++++++++++++++++++-
11 files changed, 703 insertions(+), 13 deletions(-)

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-10-17 11:28:40 Re: [pgAdmin4][Patch]: RM #3638 Syntax Error displayed when user try to create new Schedule and select start date and time in Exception
Previous Message Dave Page 2018-10-17 11:02:48 Re: fixes for browser.tests api test cases