pgsql: Avoid rare race condition in privileges.sql regression test.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid rare race condition in privileges.sql regression test.
Date: 2018-10-16 17:57:21
Message-ID: E1gCTar-0001vi-3w@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid rare race condition in privileges.sql regression test.

We created a temp table, then switched to a new session, leaving
the old session to clean up its temp objects in background. If that
took long enough, the eventual attempt to drop the user that owns
the temp table could fail, as exhibited today by sidewinder.
Fix by dropping the temp table explicitly when we're done with it.

It's been like this for quite some time, so back-patch to all
supported branches.

Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sidewinder&dt=2018-10-16%2014%3A45%3A00

Branch
------
REL9_3_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9d974fa39d264df2033ea04bf740d39acd5a3943

Modified Files
--------------
src/test/regress/expected/privileges.out | 1 +
src/test/regress/sql/privileges.sql | 1 +
2 files changed, 2 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-10-16 18:57:23 pgsql: Be smarter about age-counter overflow in formatting.c caches.
Previous Message Tom Lane 2018-10-16 17:24:48 pgsql: Fix mis-backpatch of c015ccb306ec81bca3023818c9cf0113cae25be1.