pgsql: Make PostgresNode.pm's poll_query_until() more chatty about fail

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make PostgresNode.pm's poll_query_until() more chatty about fail
Date: 2018-10-16 16:32:52
Message-ID: E1gCSH6-00008q-G9@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make PostgresNode.pm's poll_query_until() more chatty about failures.

Reporting only the stderr is unhelpful when the problem is that the
server output we're getting doesn't match what was expected. So we
should report the query output too; and just for good measure, let's
print the query we used and the output we expected.

Back-patch to 9.5 where poll_query_until was introduced.

Discussion: https://postgr.es/m/17913.1539634756@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c015ccb306ec81bca3023818c9cf0113cae25be1

Modified Files
--------------
src/test/perl/PostgresNode.pm | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-10-16 16:45:31 pgsql: Correct constness of system attributes in heap.c & prerequisites
Previous Message Tom Lane 2018-10-16 16:01:32 pgsql: Improve stability of recently-added regression test case.