From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix omissions in snprintf.c's coverage of standard *printf funct |
Date: | 2018-10-08 23:16:27 |
Message-ID: | E1g9elH-0004MK-HS@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix omissions in snprintf.c's coverage of standard *printf functions.
A warning on a NetBSD box revealed to me that pg_waldump/compat.c
is using vprintf(), which snprintf.c did not provide coverage for.
This is not good if we want to have uniform *printf behavior, and
it's pretty silly to omit when it's a one-line function.
I also noted that snprintf.c has pg_vsprintf() but for some reason
it was not exposed to the outside world, creating another way in
which code might accidentally invoke the platform *printf family.
Let's just make sure that we replace all eight of the POSIX-standard
printf family.
Also, upgrade plperl.h and plpython.h to make sure that they do
their undefine/redefine rain dance for all eight, not some random
maybe-sufficient subset thereof.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7767aadd94cd252a12fa00f6122ad4dd10455791
Modified Files
--------------
src/include/port.h | 10 ++++++++++
src/pl/plperl/plperl.h | 40 +++++++++++++++++++++++++++++++++++-----
src/pl/plpython/plpython.h | 43 +++++++++++++++++++++++++++++++++++++------
src/port/snprintf.c | 10 +++++++++-
4 files changed, 91 insertions(+), 12 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2018-10-08 23:53:08 | pgsql: Relax transactional restrictions on ALTER TYPE ... ADD VALUE (re |
Previous Message | Tom Lane | 2018-10-08 21:25:30 | pgsql: Stamp 11rc1. |