pgsql: Fix issues around EXPLAIN with JIT.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix issues around EXPLAIN with JIT.
Date: 2018-10-03 20:11:59
Message-ID: E1g7nV1-0000dh-KR@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix issues around EXPLAIN with JIT.

I (Andres) was more than a bit hasty in committing 33001fd7a7072d48327
after last minute changes, leading to a number of problems (jit output
was only shown for JIT in parallel workers, and just EXPLAIN without
ANALYZE didn't work). Lukas luckily found these issues quickly.

Instead of combining instrumentation in in standard_ExecutorEnd(), do
so on demand in the new ExplainPrintJITSummary().

Also update a documentation example of the JIT output, changed in
52050ad8ebec8d831.

Author: Lukas Fittl, with minor changes by me
Discussion: https://postgr.es/m/CAP53PkxmgJht69pabxBXJBM+0oc6kf3KHMborLP7H2ouJ0CCtQ@mail.gmail.com
Backpatch: 11, where JIT compilation was introduced

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e97c4d967ba500c7ec427a56467440f036127158

Modified Files
--------------
contrib/auto_explain/auto_explain.c | 3 +--
doc/src/sgml/jit.sgml | 8 ++------
src/backend/commands/explain.c | 29 +++++++++++++++++++++++++++--
src/backend/executor/execMain.c | 15 ---------------
src/backend/executor/execParallel.c | 9 ++++-----
src/include/commands/explain.h | 1 +
src/include/nodes/execnodes.h | 8 ++++----
7 files changed, 39 insertions(+), 34 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-10-03 20:16:36 pgsql: Ensure that snprintf.c's fmtint() doesn't overflow when printing
Previous Message Tom Lane 2018-10-03 20:05:42 pgsql: Change executor to just Assert that table locks were already obt