From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Clean up *printf macros to avoid conflict with format archetypes |
Date: | 2018-09-26 21:35:06 |
Message-ID: | E1g5HSc-0002Qg-RS@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Clean up *printf macros to avoid conflict with format archetypes.
We must define the macro "printf" with arguments, else it can mess
up format archetype attributes in builds where PG_PRINTF_ATTRIBUTE
is just "printf". Fortunately, that's easy to do now that we're
requiring C99; we can use __VA_ARGS__.
On the other hand, it's better not to use __VA_ARGS__ for the rest
of the *printf crew, so that one can take the addresses of those
functions without surprises.
I'd proposed doing this some time ago, but forgot to make it happen;
buildfarm failures subsequent to 96bf88d52 reminded me.
Discussion: https://postgr.es/m/22709.1535135640@sss.pgh.pa.us
Discussion: https://postgr.es/m/20180926190934.ea4xvzhkayuw7gkx@alap3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8b91d258844afa58e856ac354f9ba9745ff9ffb2
Modified Files
--------------
src/include/port.h | 20 +++++++-------------
src/pl/plperl/plperl.h | 5 -----
src/pl/plpython/plpython.h | 5 -----
3 files changed, 7 insertions(+), 23 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-09-26 22:23:20 | pgsql: Try another way to detect the result type of strerror_r(). |
Previous Message | Tom Lane | 2018-09-26 20:49:12 | Re: pgsql: Incorporate strerror_r() into src/port/snprintf.c, too. |