From: | Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Improve test coverage of geometric types |
Date: | 2018-09-26 09:09:02 |
Message-ID: | E1g55oc-0004Mt-OD@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve test coverage of geometric types
This commit significantly increases test coverage of geo_ops.c, adding
tests for various issues addressed by 2e2a392de3 (which went undetected
for a long time, at least partially due to not being covered).
This also removes alternative results expecting -0 on some platforms.
Instead the functions are should return the same results everywhere,
transforming -0 to 0 if needed.
The tests are added to geometric.sql file, sorted by the left hand side
of the operators. There are many cross datatype operators, so this seems
like the best solution.
Author: Emre Hasegeli
Reviewed-by: Tomas Vondra
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a3d2844852dc664718320b15cbc6d6bfa264e66e
Modified Files
--------------
src/test/regress/expected/box.out | 44 +-
src/test/regress/expected/circle.out | 39 +-
src/test/regress/expected/create_index.out | 73 +-
src/test/regress/expected/geometry.out | 4881 ++++++++++++++++++++++++++--
src/test/regress/expected/geometry_1.out | 4881 ++++++++++++++++++++++++++--
src/test/regress/expected/geometry_2.out | 563 ----
src/test/regress/expected/line.out | 272 +-
src/test/regress/expected/lseg.out | 24 +-
src/test/regress/expected/path.out | 49 +-
src/test/regress/expected/point.out | 358 +-
src/test/regress/expected/polygon.out | 200 +-
src/test/regress/sql/box.sql | 9 +
src/test/regress/sql/circle.sql | 10 +-
src/test/regress/sql/geometry.sql | 400 ++-
src/test/regress/sql/line.sql | 79 +-
src/test/regress/sql/lseg.sql | 9 +-
src/test/regress/sql/path.sql | 22 +-
src/test/regress/sql/point.sql | 10 +
src/test/regress/sql/polygon.sql | 91 +-
19 files changed, 10088 insertions(+), 1926 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2018-09-26 11:30:33 | pgsql: Update dummy CREATE ASSERTION grammar |
Previous Message | Michael Paquier | 2018-09-26 06:28:15 | pgsql: Add basic regression tests for default monitoring roles |