pgsql: Make some fixes to allow building Postgres on macOS 10.14 ("Moja

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make some fixes to allow building Postgres on macOS 10.14 ("Moja
Date: 2018-09-25 17:24:06
Message-ID: E1g4r4A-0002JC-6F@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make some fixes to allow building Postgres on macOS 10.14 ("Mojave").

Apple's latest rearrangements of the system-supplied headers have broken
building of PL/Perl and PL/Tcl. The only practical way to fix PL/Tcl is to
start using the "-isysroot" compiler flag to point to SDK-supplied headers,
as Apple expects. We must also start distinguishing where to find Perl's
headers from where to find its shared library; but that seems like good
cleanup anyway.

Extensions that formerly did something like -I$(perl_archlibexp)/CORE
should now do -I$(perl_includedir)/CORE instead. perl_archlibexp
is still the place to look for libperl.so, though.

If for some reason you don't like the default -isysroot setting, you can
override that by setting PG_SYSROOT in configure's arguments. I don't
currently think people would need to do so, unless maybe for cross-version
build purposes.

In addition, teach configure where to find tclConfig.sh. Our traditional
method of searching $auto_path hasn't worked for the last couple of macOS
releases, and it now seems clear that Apple's not going to change that.
The workaround of manually specifying --with-tclconfig was annoying
already, but Mojave's made it a lot more so because the sysroot path now
has to be included as well. Let's just wire the knowledge into configure
instead. To avoid breaking builds against non-default Tcl installations
(e.g. MacPorts) wherein the $auto_path method probably still works,
arrange to try the additional case only after all else has failed.

Back-patch to all supported versions, since at least the buildfarm
cares about that. The changes are set up to not do anything on macOS
releases that are old enough to not have functional sysroot trees.

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9590f7d6c66321214926e13558c42f0099737ce4

Modified Files
--------------
config/tcl.m4 | 13 ++++++++++++-
configure | 20 ++++++++++++++++++--
configure.in | 11 ++++++++++-
contrib/hstore_plperl/Makefile | 2 +-
contrib/jsonb_plperl/Makefile | 2 +-
src/Makefile.global.in | 1 +
src/pl/plperl/GNUmakefile | 2 +-
src/template/darwin | 12 ++++++++++++
8 files changed, 56 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-09-25 20:16:10 pgsql: Collect JIT instrumentation from workers.
Previous Message Tom Lane 2018-09-25 15:09:26 pgsql: Avoid unnecessary precision loss for pgbench's --rate target.