From: | Andrew Gierth <rhodiumtoad(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Refactor installation of extension headers. |
Date: | 2018-09-07 13:40:07 |
Message-ID: | E1fyGzX-0003N4-7L@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Refactor installation of extension headers.
Commit be54b3777 failed on gmake 3.80 due to a chained conditional,
which on closer examination could be removed entirely with some
refactoring elsewhere for a net simplification and more robustness
against empty expansions. Along the way, add some more comments.
Also make explicit in the documentation and comments that built
headers are not removed by 'make clean', since we don't typically want
that for headers generated by a separate ./configure step, and it's
much easier to add your own 'distclean' rule or use EXTRA_CLEAN than
to try and override a deletion rule in pgxs.mk.
Per buildfarm member prariedog and comments by Michael Paquier, though
all the actual changes are my fault.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7b6b167fa3bd2f968ad885ca7b024be4122a85f1
Modified Files
--------------
doc/src/sgml/extend.sgml | 14 ++++++++--
src/makefiles/pgxs.mk | 73 ++++++++++++++++++++++++++++--------------------
2 files changed, 55 insertions(+), 32 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-09-07 14:19:06 | Re: pgsql: Refactor dlopen() support |
Previous Message | Peter Eisentraut | 2018-09-07 13:13:22 | pgsql: libpq: Change "options" dispchar to normal |