| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove pg_constraint.conincluding |
| Date: | 2018-09-03 16:06:34 |
| Message-ID: | E1fwrN4-0000ma-MB@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove pg_constraint.conincluding
This column was added in commit 8224de4f42cc ("Indexes with INCLUDE
columns and their support in B-tree") to ease writing the ruleutils.c
supporting code for that feature, but it turns out to be unnecessary --
we can do the same thing with just one more syscache lookup.
Even the documentation for the new column being removed in this commit
is awkward.
Discussion: https://postgr.es/m/20180902165018.33otxftp3olgtu4t@alvherre.pgsql
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/bd47c4a9d4ec55e26e841754ce62c23ca9008e87
Modified Files
--------------
doc/src/sgml/catalogs.sgml | 8 ----
src/backend/catalog/pg_constraint.c | 21 ----------
src/backend/utils/adt/ruleutils.c | 57 +++++++++++++++++++++------
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_constraint.h | 6 ---
src/test/regress/expected/index_including.out | 40 +++++++++----------
src/test/regress/sql/index_including.sql | 10 ++---
7 files changed, 71 insertions(+), 73 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2018-09-04 03:25:11 | pgsql: During the split, set checksum on an empty hash index page. |
| Previous Message | Tomas Vondra | 2018-09-03 00:31:41 | pgsql: Fix memory leak in TRUNCATE decoding |