pgsql: Ignore server-side delays when enforcing wal_sender_timeout.

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Ignore server-side delays when enforcing wal_sender_timeout.
Date: 2018-09-01 06:03:35
Message-ID: E1fvz0R-0007DB-NE@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Ignore server-side delays when enforcing wal_sender_timeout.

Healthy clients of servers having poor I/O performance, such as
buildfarm members hamster and tern, saw unexpected timeouts. That
disagreed with documentation. This fix adds one gettimeofday() call
whenever ProcessRepliesIfAny() finds no client reply messages.
Back-patch to 9.4; the bug's symptom is rare and mild, and the code all
moved between 9.3 and 9.4.

Discussion: https://postgr.es/m/20180826034600.GA1105084@rfd.leadboat.com

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/20cd88857b3a60d40cf019872cf8a5d40888e3ae

Modified Files
--------------
src/backend/replication/walsender.c | 64 +++++++++++++++++++++----------------
1 file changed, 36 insertions(+), 28 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2018-09-01 16:51:40 pgsql: Implement "pg_ctl logrotate" command
Previous Message Andres Freund 2018-09-01 00:12:00 pgsql: Fix 8a934d677 for libc++ and make more include order resistant.