pgsql: LLVMJIT: Release JIT context after running ExprContext shutdown

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: LLVMJIT: Release JIT context after running ExprContext shutdown
Date: 2018-07-25 23:47:51
Message-ID: E1fiTVX-0006gd-6P@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

LLVMJIT: Release JIT context after running ExprContext shutdown callbacks.

Due to inlining it previously was possible that an ExprContext's
shutdown callback pointed to a JITed function. As the JIT context
previously was shut down before the shutdown callbacks were called,
that could lead to segfaults. Fix the ordering.

Reported-By: Dmitry Dolgov
Author: Andres Freund
Discussion: https://postgr.es/m/CA+q6zcWO7CeAJtHBxgcHn_hj+PenM=tvG0RJ93X1uEJ86+76Ug@mail.gmail.com
Backpatch: 11-, where JIT compilation was added

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ed7e319eb41361250ccb19379ef206b4a6d866de

Modified Files
--------------
src/backend/executor/execMain.c | 5 -----
src/backend/executor/execUtils.c | 18 +++++++++++++-----
2 files changed, 13 insertions(+), 10 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-07-26 22:18:59 pgsql: Provide plpgsql tests for cases involving record field changes.
Previous Message Andres Freund 2018-07-25 23:47:49 pgsql: LLVMJIT: Release JIT context after running ExprContext shutdown