pgsql: Be more paranoid about quoting in pg_upgrade's test script.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Be more paranoid about quoting in pg_upgrade's test script.
Date: 2018-07-21 16:06:02
Message-ID: E1fguOQ-0000k7-Kr@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Be more paranoid about quoting in pg_upgrade's test script.

Double-quote $PGDATA in "find" commands introduced by commit da9b580d8,
in case that path contains spaces or other special characters.

Adjust a few other places so that quoting is done more consistently.
None of the others are actual bugs AFAICS, but it's confusing to readers
if the same thing is done differently in different places.

Noted by Tels.

Discussion: https://postgr.es/m/c96303c04c360bbedaa04f90f515745b.squirrel@sm.webmail.pair.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5e5d131202c3494f4360f001b4805c8944e9600c

Modified Files
--------------
src/bin/pg_upgrade/test.sh | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-07-21 19:41:22 pgsql: Further portability hacking in pg_upgrade's test script.
Previous Message Tom Lane 2018-07-20 17:59:45 pgsql: Avoid unportable shell syntax in pg_upgrade's test script.