From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Rewrite comments in replication slot advance implementation |
Date: | 2018-07-19 18:17:43 |
Message-ID: | E1fgDUl-0004qg-Q6@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Rewrite comments in replication slot advance implementation
The code added by 9c7d06d60680 was a bit obscure; clarify that by
rewriting the comments. Lack of clarity has already caused bugs, so
it's a worthy goal.
Co-authored-by: Arseny Sher <a(dot)sher(at)postgrespro(dot)ru>
Co-authored-by: Michaël Paquier <michael(at)paquier(dot)xyz>
Co-authored-by: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Reviewed-by: Petr Jelínek <petr(dot)jelinek(at)2ndquadrant(dot)com>
Discussion: https://postgr.es/m/87y3fgoyrn.fsf@ars-thinkpad
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1573995f55994ee04dd0d69481de17d662ad8e88
Modified Files
--------------
src/backend/replication/logical/logical.c | 5 ++-
src/backend/replication/slotfuncs.c | 72 ++++++++++++++++++++-----------
2 files changed, 50 insertions(+), 27 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2018-07-19 18:21:40 | pgsql: Fix handling of empty uncompressed posting list pages in GIN |
Previous Message | Alexander Korotkov | 2018-07-19 18:15:20 | pgsql: Fix handling of empty uncompressed posting list pages in GIN |