From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | pgAdmin 4 commit: Fix a number of debugger execution issues. Fixes #319 |
Date: | 2018-07-17 11:51:27 |
Message-ID: | E1ffOVr-0006jN-Ka@gothos.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Fix a number of debugger execution issues. Fixes #3191
1. EPAS packages' function/procedure does not honour INOUT arguments, it converts INOUT to OUT.
2. Packages' functions and procedures are not getting listed in their respected nodes in some scenarios like procedure having INOUT argument and function with void return type
3. The Reverse engineering SQL is not correct for Packages' functions/procedures
4. In case of INOUT argument, debugger asks for mendatory input which should not.
5. Re-executing a procedure whilst direct debugging doesn't work.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8869fd6eb3b4ca02f9890bd4ae356aa1a0b2741f
Author: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Modified Files
--------------
docs/en_US/release_notes_3_2.rst | 1 +
.../schemas/packages/edbfuncs/__init__.py | 28 +----
.../9.2_plus => edbfunc/ppas/11_plus}/get_oid.sql | 2 +-
.../ppas/11_plus}/properties.sql | 4 +-
.../templates/edbfunc/ppas/9.1_plus/get_body.sql | 5 -
.../templates/edbfunc/ppas/9.1_plus/node.sql | 11 --
.../templates/edbfunc/ppas/9.2_plus/get_body.sql | 6 -
.../templates/edbfunc/ppas/9.2_plus/node.sql | 10 --
.../templates/edbfunc/ppas/default/get_body.sql | 1 +
.../ppas/{9.1_plus => default}/get_name.sql | 0
.../edbfunc/ppas/{9.1_plus => default}/get_oid.sql | 0
.../ppas/{9.1_plus => default}/get_schema.sql | 0
.../9.1_plus => edbfunc/ppas/default}/node.sql | 2 +-
.../ppas/{9.2_plus => default}/properties.sql | 4 +-
.../edbfunc/ppas/{9.1_plus => default}/stats.sql | 0
.../edbproc/ppas/{9.1_plus => 11_plus}/get_oid.sql | 2 +-
.../ppas/11_plus}/properties.sql | 4 +-
.../templates/edbproc/ppas/9.1_plus/get_body.sql | 5 -
.../templates/edbproc/ppas/9.1_plus/get_name.sql | 3 -
.../templates/edbproc/ppas/9.1_plus/get_schema.sql | 6 -
.../templates/edbproc/ppas/9.1_plus/stats.sql | 8 --
.../templates/edbproc/ppas/9.2_plus/get_body.sql | 6 -
.../templates/edbproc/ppas/9.2_plus/get_name.sql | 3 -
.../templates/edbproc/ppas/9.2_plus/get_schema.sql | 6 -
.../templates/edbproc/ppas/9.2_plus/stats.sql | 8 --
.../templates/edbproc/ppas/default/get_body.sql | 1 +
.../9.2_plus => edbproc/ppas/default}/get_name.sql | 0
.../9.2_plus => edbproc/ppas/default}/get_oid.sql | 0
.../ppas/default}/get_schema.sql | 0
.../edbproc/ppas/{9.2_plus => default}/node.sql | 2 +-
.../ppas/{9.2_plus => default}/properties.sql | 2 +-
.../9.2_plus => edbproc/ppas/default}/stats.sql | 0
.../schemas/packages/edbfuncs/tests/__init__.py | 16 +++
.../edbfuncs/tests/test_package_edbfuncs_get.py | 138 +++++++++++++++++++++
web/pgadmin/tools/debugger/static/js/direct.js | 1 -
.../debugger/sql/get_function_debug_info.sql | 4 +
36 files changed, 176 insertions(+), 113 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2018-07-17 11:51:39 | Re: [pgAdmin4][Patch]: Fix RM #3191 : Debug option is not working |
Previous Message | Dave Page | 2018-07-17 11:43:58 | Re: [pgAdmin4][Patch]: RM #3446 plpgsql keyword should displayed in SQL pane for EPAS-11 |